Deprecate guess work in processPriceSet #20678
Conversation
|
(Standard links)
|
|
decent amount of test fails here |
|
@seamuslee001 yep - seems to be mostly because tests aren't using the order api & are doing weird setup - I think the answer is to make the order api easier to use - see #20681 api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #1 |
This changes the order api so that it is not necessary to figure out the details of the default price set when using it to create memberships.
Testing to see how much of this we can deprecate - line items should be 'complete' before reaching the processing function
eileenmcnaughton
force-pushed
the
loadlines
branch
from
7f280da to
4ec7a83
Compare
|
Jenkins re test this please |
|
@seamuslee001 it's basically stalled on #20678 - once that is merged I'll get this passing & finish the financial fixes which is 1/3 of what membership api is stalled on (the other is the #20672 & something I now know how to fix but haven't) |
|
Closing for now - stalled on review-ready PRs - note the ACTUAL change in here is |
Testing to see how much of this we can deprecate - line items should
be 'complete' before reaching the processing function
Overview
A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note